necouchman commented on pull request #490:
URL: https://github.com/apache/guacamole-client/pull/490#issuecomment-903154835


   @mike-jumper Okay, I've started down path that I think is approximately what 
you're suggesting, while trying to avoid breaking everything in the process. 
So, instead of making `getProperty()` and/or `getRequiredProperty()` return a 
collection, I added a new set of methods, `getPropertyCollection()` and 
`getRequiredPropertyCollection()` that are intended to parse into a Collection. 
   
   This would rely on each of the properties to implement a new 
`getValueCollection()` method, which I've provided a default implementation for 
in `GuacamoleProperty` that basically says "not yet implemented."
   
   Let me know if this looks good, sane, reasonable, etc., or if there's a 
better solution? I could break everything and make `getValue()`, 
`getProperty()`, and `getRequiredProperty()` return collections instead of 
individual values, if that's preferable?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to