necouchman commented on a change in pull request #650:
URL: https://github.com/apache/guacamole-client/pull/650#discussion_r738319882
##########
File path:
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/MySQLAuthenticationProviderModule.java
##########
@@ -87,9 +87,12 @@ public MySQLAuthenticationProviderModule(MySQLEnvironment
environment)
driverProperties.setProperty("sslMode", sslMode.getDriverValue());
// For compatibility, set legacy useSSL property when SSL is disabled.
- if (sslMode == MySQLSSLMode.DISABLED)
+ if (sslMode == MySQLSSLMode.DISABLED) {
driverProperties.setProperty("useSSL", "false");
-
+ } else {
Review comment:
Please don't "cuddle" the braces here with the `else` statement. Should
be:
```
}
else {
```
You don't even need the braces at all, but not so concerned about that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
