jbpaux commented on a change in pull request #615:
URL: https://github.com/apache/guacamole-client/pull/615#discussion_r742256600
##########
File path: guacamole-docker/bin/start.sh
##########
@@ -594,6 +594,46 @@ END
}
+## Adds properties to guacamole.properties which select the SAML
+## authentication provider, and configure it to connect to the specified SAML
+## provider.
+##
+associate_saml() {
+
+ # Verify required parameters are present
+ if [ -z "$SAML_IDP_METADATA_URL" ]
+ then
+ cat <<END
+FATAL: Missing required environment variables
+-------------------------------------------------------------------------------
+If using an openid authentication, you must provide each of the following
Review comment:
fixed :)
##########
File path: guacamole-docker/bin/start.sh
##########
@@ -594,6 +594,46 @@ END
}
+## Adds properties to guacamole.properties which select the SAML
+## authentication provider, and configure it to connect to the specified SAML
+## provider.
+##
+associate_saml() {
+
+ # Verify required parameters are present
+ if [ -z "$SAML_IDP_METADATA_URL" ]
+ then
+ cat <<END
+FATAL: Missing required environment variables
+-------------------------------------------------------------------------------
+If using an openid authentication, you must provide each of the following
+environment variables:
+
+ SAML_IDP_METADATA_URL The URI of the XML metadata file that from
the SAML Identity
+ Provider
+END
+ exit 1;
+ fi
+
+ # Update config file
+ set_property "saml-idp-metadata-url"
"$SAML_IDP_METADATA_URL"
Review comment:
I've put it optional :)
##########
File path: guacamole-docker/bin/start.sh
##########
@@ -594,6 +594,46 @@ END
}
+## Adds properties to guacamole.properties which select the SAML
+## authentication provider, and configure it to connect to the specified SAML
+## provider.
+##
Review comment:
done
##########
File path: guacamole-docker/bin/start.sh
##########
@@ -830,6 +870,12 @@ if [ -n "$OPENID_AUTHORIZATION_ENDPOINT" ]; then
INSTALLED_AUTH="$INSTALLED_AUTH openid"
fi
+# Use SAML if specified
+if [ -n "$SAML_IDP_METADATA_URL" ]; then
Review comment:
I've implemented the logic.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
