Noor-glyp commented on a change in pull request #350:
URL: https://github.com/apache/guacamole-server/pull/350#discussion_r743413152
##########
File path: src/terminal/terminal.c
##########
@@ -1590,6 +1590,23 @@ static int __guac_terminal_send_key(guac_terminal* term,
int keysym, int pressed
if (keysym == 0xFF54 || keysym == 0xFF99) return
guac_terminal_send_string(term, "\x1B[B"); /* Down */
}
+ if (term->mod_shift)
+ {
Review comment:
1. I resolved the formatting issue. And rewrote the commit message.
2. Well if function key is pressed without Shift and with Shift. Both
generate different key events. For the Ctrl+Function or Ctrl+Alt function or
Ctrl+Alt+Shift +Function (This opens the menu and refocuses it to menu so
function key hold with it, I am not sure the function key event will pass
through.)
##########
File path: src/terminal/terminal.c
##########
@@ -1590,6 +1590,23 @@ static int __guac_terminal_send_key(guac_terminal* term,
int keysym, int pressed
if (keysym == 0xFF54 || keysym == 0xFF99) return
guac_terminal_send_string(term, "\x1B[B"); /* Down */
}
+ if (term->mod_shift)
+ {
Review comment:
Will add different functionality for the Alt and Ctrl hold and add to
this PR branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
