xens commented on a change in pull request #348:
URL: https://github.com/apache/guacamole-server/pull/348#discussion_r753706472
##########
File path: Dockerfile
##########
@@ -148,7 +148,8 @@ RUN apt-get update
# Link FreeRDP plugins into proper path
RUN ${PREFIX_DIR}/bin/link-freerdp-plugins.sh \
- ${PREFIX_DIR}/lib/freerdp2/libguac*.so
+ ${PREFIX_DIR} \
+ /lib/freerdp2/libguac*.so
Review comment:
My initial understanding was that setting `LD_LIBRARY_PATH` to
`/usr/local/guacamole/lib` would be sufficient as everything was available
under that path, including the FreeRDP plugins, but if we skip the
`link-freerdp-plugins.sh`, `guacd` complains that it can't load
`"guac-common-svc" from /usr/lib/x86_64-linux-gnu/freerdp2/` so that's why I
tried to adapt the `link-freerdp-plugins.sh`, but I'm happy to help if we can
get rid of it and simplify this process.
> The guacamole-server build automatically locates the proper directory for
FreeRDP plugins and installs its plugins there
I'm not sure to understand if you mean that it must already work as-is
without `link-freerdp-plugins.sh` (which doesn't seems to be the case), or if
it means that we need to adapt something based on what has been done during the
build process (if that's the case could you give me pointers?).
##########
File path: Dockerfile
##########
@@ -22,7 +22,7 @@
#
# The Debian image that should be used as the basis for the guacd image
-ARG DEBIAN_BASE_IMAGE=buster-slim
+ARG DEBIAN_BASE_IMAGE=bullseye-slim
Review comment:
Good idea, will do.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
