holograph commented on a change in pull request #271:
URL: https://github.com/apache/guacamole-server/pull/271#discussion_r771874510
##########
File path: src/guacd/connection.c
##########
@@ -278,10 +278,18 @@ static int guacd_route_connection(guacd_proc_map* map,
guac_socket* socket) {
proc = guacd_proc_map_retrieve(map, identifier);
new_process = 0;
- /* Warn if requested connection does not exist */
- if (proc == NULL)
- guacd_log(GUAC_LOG_INFO, "Connection \"%s\" does not exist.",
- identifier);
+ /* Warn and ward off client if requested connection does not exist */
+ if (proc == NULL) {
+ char message[2048];
+
+ snprintf(message, sizeof(message),
+ "Connection \"%s\" does not exist", identifier);
+
+ guacd_log(GUAC_LOG_INFO, message);
Review comment:
Woah, it's been a while. I am no longer with my previous employer and
have no real-world way of testing this (nor even a toolchain to build it
with...). Hopefully it's still somewhat useful as-is.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
