mike-jumper commented on pull request #369: URL: https://github.com/apache/guacamole-server/pull/369#issuecomment-1047200904
I'm a bit late to this party, but: 1. We're getting some build failures when the `ldd` check runs, indicating there are some missing symbols that may cause problems for users that attempt to link against the library. 2. The `guac_common_clipboard` structure is actually an internal part of guacamole-server (the internal common library), so this library can't be used as-is. There's no way for a downstream user to create an instance of `guac_common_clipboard`. That aspect will need to either be abstracted away or additionally made public. 3. I suggest renaming to `libguac-terminal` rather than `libguac_terminal` to match convention. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
