jmuehlner commented on a change in pull request #712:
URL: https://github.com/apache/guacamole-client/pull/712#discussion_r840027336
##########
File path:
guacamole/src/main/frontend/src/app/settings/directives/guacSettingsConnectionHistory.js
##########
@@ -89,6 +89,37 @@
angular.module('settings').directive('guacSettingsConnectionHistory', [function
'entry.remoteHost'
]);
+ /**
+ * The names of sortable properties supported by the REST API that
+ * correspond to the properties that may be stored within
+ * $scope.order.
+ *
+ * @type {!Object.<string, string>}
Review comment:
I know this is a convention we're doing everywhere, so I'm not
suggesting we change it - but doesn't it feel a bit unnecessary to specify that
the keys are strings here? The language doesn't allow non-string keys.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
