necouchman commented on PR #721: URL: https://github.com/apache/guacamole-client/pull/721#issuecomment-1105295960
@MarcelloModica A few issues with this pull request: * I'm not entirely sure what you're trying to do, or if you even meant to make a pull request to the main repo? * If you are intending to contribute something, please make sure that you have a Jira issue for it, that the Jira issue describes the changes, and that you tag the pull request and your commits with the Jira issue (GUACAMOLE-XXXX:). * Make sure that your commits are clean - this PR contains at least one merge commit, which should not be present, along with many commits that update identical things multiple times. Commits should be squashed into a smaller number of commits that group changes appropriately. * It looks like some of these commits add various IDE files along with some Docker functionality that I don't think we want in the main codebase. This stuff should be removed. We are happy to put IDE-specific items into the `.gitignore` file so that those items are not picked up by git, but we don't want IDE configurations in the source code. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
