necouchman commented on PR #728: URL: https://github.com/apache/guacamole-client/pull/728#issuecomment-1133769242
Thanks, @Niubbo75! Overall it looks okay -the one issue I see is the commit messages. They're all the same, and not quite as descriptive as they could be. I would suggest, for this type of issue, that you just squash all of the commits together into a single commit (git rebase -i, then git push -f), and make the commit message a bit more descriptive. There's a good page that helps with pointers on commit messages, here: https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
