jmuehlner commented on code in PR #730: URL: https://github.com/apache/guacamole-client/pull/730#discussion_r884945931
########## extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/HistoryTrackingTunnel.java: ########## @@ -0,0 +1,72 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.guacamole.auth.jdbc; + +import java.util.Date; + +import org.apache.guacamole.GuacamoleException; +import org.apache.guacamole.auth.jdbc.connection.ConnectionRecordMapper; +import org.apache.guacamole.auth.jdbc.connection.ConnectionRecordModel; +import org.apache.guacamole.net.DelegatingGuacamoleTunnel; +import org.apache.guacamole.net.GuacamoleTunnel; + +/** + * Tunnel implementation which automatically writes an end date for the + * provided connection history record model using the provided connection + * history mapper, when the tunnel is closed. + */ +public class HistoryTrackingTunnel extends DelegatingGuacamoleTunnel { + + /** + * The connection for which this tunnel was established. + */ + private final ConnectionRecordMapper connectionRecordMapper; + + /** + * The user for which this tunnel was established. + */ + private final ConnectionRecordModel connectionRecordModel; + + /** + * Creates a new HistoryTrackingTunnel that wraps the given tunnel, + * automatically setting the end date for the provided connection history records, + * using the provided connection history record mapper. + */ Review Comment: Oops, added! ########## extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/HistoryTrackingUserContext.java: ########## @@ -0,0 +1,74 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.guacamole.auth.jdbc; + +import org.apache.guacamole.GuacamoleException; +import org.apache.guacamole.auth.jdbc.connection.ConnectionRecordMapper; +import org.apache.guacamole.net.auth.Connection; +import org.apache.guacamole.net.auth.DelegatingUserContext; +import org.apache.guacamole.net.auth.Directory; +import org.apache.guacamole.net.auth.UserContext; + +/** + * DelegatingUserContext implementation which writes connection history records + * when connections are established and closed. + */ +public class HistoryTrackingUserContext extends DelegatingUserContext { + + /** + * The remote host that the user associated with the user context + * connected from. + */ + private final String remoteHost; + + /** + * The connection record mapper to use when writing history entries for + * established connections. + */ + private final ConnectionRecordMapper connectionRecordMapper; + + /** + * Creates a new HistoryTrackingUserContext which wraps the given + * UserContext, allowing for tracking of connection history external to + * this authentication provider. + * + * @param userContext + * The UserContext to wrap. + * + * @param string Review Comment: Yep, my bad. Fixed now. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
