jmuehlner commented on code in PR #383: URL: https://github.com/apache/guacamole-server/pull/383#discussion_r892877371
########## src/terminal/terminal/terminal.h: ########## @@ -279,6 +289,33 @@ guac_terminal_options* guac_terminal_options_create( */ void guac_terminal_free(guac_terminal* term); +/** + * Calculate the available space within the terminal Review Comment: Sorry to be such a stickler about style, but block comments should end in periods. Also, a little bit more detail about how the function works is useful to understand the function at a glance. In this case, it would be good to mention something about the calculation results being stuffed into the provided int* pointers. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
