jmuehlner commented on code in PR #739:
URL: https://github.com/apache/guacamole-client/pull/739#discussion_r915168415
##########
extensions/guacamole-vault/modules/guacamole-vault-ksm/src/main/java/org/apache/guacamole/vault/ksm/secret/KsmSecretService.java:
##########
@@ -60,6 +76,53 @@ public class KsmSecretService implements VaultSecretService {
@Inject
private KsmConfigurationService confService;
+ /**
+ * Factory for creating KSM client instances.
+ */
+ @Inject
+ private KsmClientFactory ksmClientFactory;
+
+ /**
+ * A map of base-64 encoded JSON KSM config blobs to associated KSM client
instances.
+ * The `null` entry in this Map is associated with the KSM configuration
parsed
+ * from the guacamole.properties config file. A distinct KSM client will
exist for
+ * every KSM config.
+ */
+ private final ConcurrentMap<String, KsmClient> ksmClientMap = new
ConcurrentHashMap<>();
+
+ /**
+ * Create and return a KSM cache for the provided KSM config if not already
+ * present in the cache map, otherwise return the existing cache entry.
Review Comment:
Ugh, yes. I _think_ I got them all now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
