mike-jumper commented on code in PR #746:
URL: https://github.com/apache/guacamole-client/pull/746#discussion_r931419287
##########
guacamole/src/main/java/org/apache/guacamole/tunnel/InputStreamInterceptingFilter.java:
##########
@@ -112,9 +112,8 @@ private void readNextBlob(InterceptedStream<InputStream>
stream) {
// End stream if no more data
if (length == -1) {
- // Close stream, send end if the stream is still valid
- if (closeInterceptedStream(stream))
- sendEnd(stream.getIndex());
+ // Close stream
+ closeInterceptedStream(stream);
Review Comment:
@elijahnicpon I'm not seeing where the `end` instruction is sent now that
this `sendEnd()` call has been removed. I do see that `ManagedFileUpload`
updates its own understanding of the stream state, but the associated stream
will still be active and consuming resources within guacd until `end` is
received.
Can you point to where the relevant `end` instruction is sent from, if it
will not be here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
