jmuehlner commented on code in PR #748:
URL: https://github.com/apache/guacamole-client/pull/748#discussion_r932547974
##########
extensions/guacamole-auth-sso/modules/guacamole-auth-sso-saml/src/main/java/org/apache/guacamole/auth/saml/acs/SAMLService.java:
##########
@@ -98,6 +116,9 @@ public URI createRequest() throws GuacamoleException {
throw new GuacamoleServerException("SAML IdP redirect could not "
+ "be generated due to an error in the URI syntax: "
+ e.getMessage());
+ } catch (SettingsException e) {
+ throw new GuacamoleServerException("SAML Settings errors: "
Review Comment:
Sure, I dug into the source to find the situation where it would throw this
error. Will update.
##########
extensions/guacamole-auth-sso/modules/guacamole-auth-sso-saml/src/main/java/org/apache/guacamole/auth/saml/acs/SAMLService.java:
##########
@@ -98,6 +116,9 @@ public URI createRequest() throws GuacamoleException {
throw new GuacamoleServerException("SAML IdP redirect could not "
+ "be generated due to an error in the URI syntax: "
+ e.getMessage());
+ } catch (SettingsException e) {
Review Comment:
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
