jmuehlner commented on code in PR #751:
URL: https://github.com/apache/guacamole-client/pull/751#discussion_r940715712
##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/src/main/java/org/apache/guacamole/auth/jdbc/JDBCAuthenticationProviderService.java:
##########
@@ -159,13 +182,21 @@ else if (!databaseRestrictionsApplicable) {
}
+ @Override
+ public ModeledUserContext getUserContext(AuthenticationProvider
authenticationProvider,
+ AuthenticatedUser authenticatedUser) throws GuacamoleException {
+
+ // Do not force refresh unless updateUserContext is explicitly called
+ return getUserContext(authenticationProvider, authenticatedUser,
false);
+ }
+
@Override
public UserContext updateUserContext(AuthenticationProvider
authenticationProvider,
UserContext context, AuthenticatedUser authenticatedUser,
Credentials credentials) throws GuacamoleException {
- // No need to update the context
- return context;
+ // Force-refresh the user context
+ return getUserContext(authenticationProvider, authenticatedUser, true);
Review Comment:
I still don't get why that's needed, though. I mean, getting rid of that
check just forces it to reload from the DB every time, which is what we want.
That check is what `forceRefresh` existed to specifically disable, which is
what's needed to get the user context to actually refresh when
`updateUserContext` is called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
