jmuehlner commented on code in PR #753:
URL: https://github.com/apache/guacamole-client/pull/753#discussion_r943010166
##########
extensions/guacamole-vault/modules/guacamole-vault-ksm/src/main/java/org/apache/guacamole/vault/ksm/secret/KsmClient.java:
##########
@@ -250,13 +291,38 @@ private void validateCache() throws GuacamoleException {
String hostname = recordService.getHostname(record);
addRecordForHost(record, hostname);
+ // ... and domain
+ String domain = recordService.getDomain(record);
+ addRecordForDomain(record, domain);
+
+ // Fetch the username
+ String username = recordService.getUsername(record);
+
+ // If domains should be split out from usernames
+ if (username != null &&
confService.getSplitWindowsUsernames()) {
+
+ // Attempt to split the domain of the username
+ WindowsUsername usernameAndDomain = (
+
WindowsUsername.splitWindowsUsernameFromDomain(username));
Review Comment:
Ah, yes good call. The functionality was a bit goofed, but it should be
better now. The `KEEPER_USER_` tokens will now ALSO match on domain (if
configured to do so. false by default).
The behavior seems a lot more sane now - let me know what you think.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
