myamoto commented on PR #388: URL: https://github.com/apache/guacamole-server/pull/388#issuecomment-1222043840
Hi @mike-jumper, Thanks for your prompt and thorough reply. > The `latest` tag for the Docker image is already rebuilt nightly to incorporate any patches released by package maintainers and the underlying distro image. These changes improve on that further, but you don't _need_ these changes to have an up-to-date image. I like freezing the image at some point in time, forking the code at a precise commit to be able to build it again if needed, avoiding possible regressions with latest built. > This should happen automatically via: > > https://github.com/apache/guacamole-server/blob/15f6e9f678a584b0fe374ddd279ec453515008ae/Dockerfile#L141-L146 > > and: > > https://github.com/apache/guacamole-server/blob/15f6e9f678a584b0fe374ddd279ec453515008ae/Dockerfile#L178 > > See: https://github.com/apache/guacamole-server/blob/15f6e9f678a584b0fe374ddd279ec453515008ae/src/guacd-docker/bin/list-dependencies.sh > > Sounds like there must be something the above script is missing that prevents Pango from getting recognized as a dependency. Cairo is recognized and pulled in: > > ``` > $ docker run --rm guacd cat /opt/guacamole/DEPENDENCIES > brotli-libs > cairo > expat > fontconfig > freetype > libbz2 > libcrypto1.1 > libjpeg-turbo > libpng > libssl1.1 > libuuid > libwebp > libx11 > libxau > libxcb > libxdmcp > libxext > libxrender > musl > pixman > zlib > $ > ``` That's great thanks for the clues. Thank you guys for such reactivity on PR 389. I tested it and it's working seemlessly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
