jmuehlner commented on code in PR #751:
URL: https://github.com/apache/guacamole-client/pull/751#discussion_r957853551
##########
extensions/guacamole-vault/modules/guacamole-vault-ksm/src/main/java/org/apache/guacamole/vault/ksm/secret/KsmSecretService.java:
##########
@@ -304,6 +325,72 @@ private String getConnectionGroupKsmConfig(
}
+ /**
+ * Returns true if user-level KSM configuration is enabled for the given
+ * Connectable, false otherwise.
+ *
+ * @param connectable
+ * The connectable to check for whether user-level KSM configs are
+ * enabled.
+ *
+ * @return
+ * True if user-level KSM configuration is enabled for the given
+ * Connectable, false otherwise.
+ */
+ private boolean isKsmUserConfigEnabled(Connectable connectable) {
+
+ // If it's a connection, user-level config is enabled IFF the
appropriate
+ // attribute is set to true
+ if (connectable instanceof Connection)
+ return KsmAttributeService.TRUTH_VALUE.equals(((Connection)
connectable).getAttributes().get(
+ KsmAttributeService.KSM_USER_CONFIG_ENABLED_ATTRIBUTE));
+
+ // KSM token replacement is not enabled for balancing groups, so for
+ // now, user-level KSM configs will be explicitly disabled.
+ // TODO: If token replacement is implemented for balancing groups,
+ // implement this functionality for them as well.
+ return false;
Review Comment:
Updated to be more explicit about what would need to be implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
