jmuehlner commented on code in PR #392:
URL: https://github.com/apache/guacamole-server/pull/392#discussion_r959007643
##########
src/protocols/rdp/settings.c:
##########
@@ -1529,7 +1549,20 @@ void guac_rdp_push_settings(guac_client* client,
case GUAC_SECURITY_ANY:
rdp_settings->RdpSecurity = TRUE;
rdp_settings->TlsSecurity = TRUE;
- rdp_settings->NlaSecurity = guac_settings->username &&
guac_settings->password;
+
+ /* Explicitly disable NLA if FIPS mode is enabled - it won't work
*/
+ if (guac_fips_enabled()) {
+
+ guac_client_log(client, GUAC_LOG_WARNING,
+ "Disabling NLA security mode when FIPS mode is
enabled.");
Review Comment:
Ah oops, I had updated this to be INFO, but that change got lost somewhere.
I'll put it back.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
