mike-jumper commented on code in PR #768:
URL: https://github.com/apache/guacamole-client/pull/768#discussion_r993791179


##########
guacamole/src/main/java/org/apache/guacamole/rest/auth/HashTokenSessionMap.java:
##########
@@ -226,6 +226,7 @@ public GuacamoleSession remove(String authToken) {
     @Override
     public void shutdown() {
         executor.shutdownNow();
+        sessionMap.values().stream().forEach(GuacamoleSession::invalidate);

Review Comment:
   Some of that should be captured by the commit message of the commit that 
introduced this line (affdcc8e425786ddd99a1375a93fce7c0a1307ef):
   
   >  GUACAMOLE-1224: Ensure all user sessions are explicitly invalidated prior 
to application shutdown.
   
   I can add a similar comment to clarify the code here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to