mike-jumper commented on code in PR #770:
URL: https://github.com/apache/guacamole-client/pull/770#discussion_r1007196351
##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/pom.xml:
##########
@@ -57,14 +57,35 @@
<dependency>
<groupId>org.mybatis</groupId>
<artifactId>mybatis</artifactId>
- <version>3.5.9</version>
+ <version>3.5.11</version>
</dependency>
<!-- MyBatis Guice -->
<dependency>
<groupId>org.mybatis</groupId>
<artifactId>mybatis-guice</artifactId>
- <version>3.10</version>
+ <version>3.17</version>
+ <exclusions>
+
+ <!-- This dependency appears to be necessary only to provide an
Review Comment:
Well, the inclusion in `extensions/pom.xml` was an initial experiment that
was inadvertently committed - I'll get rid of that.
It's excluded because we have that build-time sanity check that fails the
build if any extension bundles SLF4J binaries (to prevent compatibility issues
with the SLF4J bundled with the webapp). Thus, we have to do one of the
following:
* Exclude the dependency if it can be verified that it's unused (I went this
route)
* Override that enforcer rule within this `pom.xml` to explicitly allow
bundling of `jcl-over-slf4j`.
I went the exclusion route as it was easy to verify that the code in
question doesn't use commons-logging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
