necouchman commented on code in PR #358:
URL: https://github.com/apache/guacamole-server/pull/358#discussion_r1016684763
##########
src/libguac/guacamole/protocol-types.h:
##########
@@ -306,9 +306,40 @@ typedef enum guac_protocol_version {
* allowing connections in guacd to request information from the client and
* await a response.
*/
- GUAC_PROTOCOL_VERSION_1_3_0 = 0x010300
+ GUAC_PROTOCOL_VERSION_1_3_0 = 0x010300,
+
+ /**
+ * Protocol version 1.5.0, which supports the "msg" instruction, allowing
+ * messages to be sent to the client, and adds support for the "username"
+ * handshake instruction.
+ */
+ GUAC_PROTOCOL_VERSION_1_5_0 = 0x010500
} guac_protocol_version;
+/**
+ * A type that represents codes for human-readable messages sent by the "msg"
+ * instruction to the Client, that will be displayed in the client's browser.
+ * The codes will be interpreted by the client into translatable messages, and
+ * make take arguments, as noted below.
+ */
+typedef enum guac_msg_client {
+
+ /**
+ * A message that notifies the owner of a connection that another user has
+ * joined their connection. There should be a single argument, the username
+ * of the user who has joined.
+ */
+ GUAC_MSG_CLIENT_JOINED = 0x0001,
+
+ /**
+ * A message that notifies the owner of a connection that another user has
+ * left their connection. There should be a single argument provided, the
+ * username of the user who has left.
+ */
+ GUAC_MSG_CLIENT_LEFT = 0x0002
+
+} guac_msg_client;
Review Comment:
Good with me - has been renamed.
##########
src/libguac/guacamole/protocol-types.h:
##########
@@ -306,9 +306,40 @@ typedef enum guac_protocol_version {
* allowing connections in guacd to request information from the client and
* await a response.
*/
- GUAC_PROTOCOL_VERSION_1_3_0 = 0x010300
+ GUAC_PROTOCOL_VERSION_1_3_0 = 0x010300,
+
+ /**
+ * Protocol version 1.5.0, which supports the "msg" instruction, allowing
+ * messages to be sent to the client, and adds support for the "username"
+ * handshake instruction.
+ */
+ GUAC_PROTOCOL_VERSION_1_5_0 = 0x010500
} guac_protocol_version;
+/**
+ * A type that represents codes for human-readable messages sent by the "msg"
+ * instruction to the Client, that will be displayed in the client's browser.
+ * The codes will be interpreted by the client into translatable messages, and
+ * make take arguments, as noted below.
+ */
+typedef enum guac_msg_client {
+
+ /**
+ * A message that notifies the owner of a connection that another user has
+ * joined their connection. There should be a single argument, the username
+ * of the user who has joined.
+ */
+ GUAC_MSG_CLIENT_JOINED = 0x0001,
+
+ /**
+ * A message that notifies the owner of a connection that another user has
+ * left their connection. There should be a single argument provided, the
+ * username of the user who has left.
+ */
+ GUAC_MSG_CLIENT_LEFT = 0x0002
Review Comment:
Renamed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
