mike-jumper commented on PR #783: URL: https://github.com/apache/guacamole-client/pull/783#issuecomment-1366980250
What does `setAttributes()` receive when the timezone field has been cleared? On Wed, Dec 28, 2022, 1:02 PM Alexander Leitner ***@***.***> wrote: > ***@***.**** commented on this pull request. > ------------------------------ > > In > guacamole/src/main/java/org/apache/guacamole/rest/user/UserResource.java > <https://github.com/apache/guacamole-client/pull/783#discussion_r1058588140> > : > > > @@ -150,6 +150,10 @@ public void updateObject(APIUser modifiedObject) throws GuacamoleException { > throw e; > } > > + /* Force updateObject to save the timezone when it is empty */ > + if (modifiedObject.getAttributes().get("timezone") == null) > + modifiedObject.getAttributes().put("timezone", ""); > + > > The alternative that I can think of would be to have the empty timezone be > represented as an empty string rather than null on the javascript side > > — > Reply to this email directly, view it on GitHub > <https://github.com/apache/guacamole-client/pull/783#discussion_r1058588140>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/ABDLCSMFKYP3RUYWQZTOG6DWPSTHDANCNFSM6AAAAAATLRDYLM> > . > You are receiving this because you are subscribed to this thread.Message > ID: ***@***.***> > -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
