necouchman commented on code in PR #794: URL: https://github.com/apache/guacamole-client/pull/794#discussion_r1107852630
########## guacamole-docker/bin/start.sh: ########## @@ -1064,6 +1069,11 @@ fi set_property "guacd-hostname" "$GUACD_HOSTNAME" set_property "guacd-port" "$GUACD_PORT" +# A comma-separated list of the identifiers of authentication providers that +# should be allowed to fail internally without aborting the authentication process +set_property "skip-if-unavailable" "$SKIP_IF_UNAVAILABLE" Review Comment: Shouldn't this be `set_optional_property`? Using `set_property` will put an empty string in there or possibly other unexpected results if it isn't present. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
