marvin-enthus commented on code in PR #795:
URL: https://github.com/apache/guacamole-client/pull/795#discussion_r1112167375
##########
extensions/guacamole-auth-json/src/main/java/org/apache/guacamole/auth/json/connection/ConnectionService.java:
##########
@@ -176,6 +177,22 @@ public GuacamoleTunnel connect(UserData.Connection
connection,
String hostname = proxyConfig.getHostname();
int port = proxyConfig.getPort();
+ // handle guacd-[hostname/port/ssl] overrides
+ Map<String, String> params = connection.getParameters();
Review Comment:
Hi Mike. I Just pushed an other commit migrating this to connection level.
Currently i'm not sure about the best approach - I've allinged the java
class with the current camelCase, so the settings are currently also in
camelCase:
```
{
"username" : "arbitraryUsername",
"expires" : TIMESTAMP,
"connections" : {
"Connection Name" : {
"protocol" : "PROTOCOL",
"guacdHostname" : "my-other-guacd-host",
"guacdPort" : 4822,
"guacdSsl" : false,
"parameters" : {
"name1" : "value1",
"name2" : "value2",
...
}
},
...
}
}
```
But that's not matching the names in other places. I could set some
annotations for the jackson data mapper, but haven't found any json annotation
on the code - so i'm not sure about this...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
