khoek opened a new pull request, #418: URL: https://github.com/apache/guacamole-server/pull/418
As kindly described by Mike Powers in GUACAMOLE-1717, using GNOME Remote Desktop (GRD) with gaucd causes a clearly junk/corrupt cursor to be rendered. Mike tracked this down to use of uninitialized memory (`data`) in `guac_rdp_pointer_new()` when the call to `freerdp_image_copy_from_pointer_data()` is skipped because connecting to GRD causes `pointer->andMaskData` to be `NULL`. As described in the ticket, the `if` guard (on line 49) causing this to happen is not necessary because FreeRDP protects against this case internally (at least in 2.0 versions), and at any rate there is a bug because if FreeRDP can't handle this situation we should at least zero `data` instead of returning garbage. Tested on Ubuntu 22.10 with the fix applied on top of master. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
