mike-jumper commented on code in PR #821:
URL: https://github.com/apache/guacamole-client/pull/821#discussion_r1160087604
##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-mysql/src/main/java/org/apache/guacamole/auth/mysql/conf/MySQLEnvironment.java:
##########
@@ -104,6 +104,20 @@ public class MySQLEnvironment extends JDBCEnvironment {
* The default SSL mode for connecting to MySQL servers.
*/
private final MySQLSSLMode DEFAULT_SSL_MODE = MySQLSSLMode.PREFERRED;
+
+ /**
+ * The default maximum number of identifiers/parameters to be included in
a
+ * single batch when executing SQL statements for MySQL and MariaDB.
+ *
+ * MySQL and MariaDB impose a limit on the maximum size of a query,
+ * determined by the max_allowed_packet configuration variable. A value of
+ * 1000 is chosen to accommodate the max_allowed_packet limit without
+ * exceeding it.
+ *
+ * @see
https://dev.mysql.com/doc/refman/8.0/en/server-system-variables.html#sysvar_max_allowed_packet
+ * @see
https://mariadb.com/kb/en/server-system-variables/#max_allowed_packet
+ */
+ private static final int BATCH_SIZE = 1000;
Review Comment:
As the default value for `*-batch-size`, this should be `DEFAULT_BATCH_SIZE`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
