mike-jumper commented on code in PR #826:
URL: https://github.com/apache/guacamole-client/pull/826#discussion_r1160808648
##########
guacamole-common-js/pom.xml:
##########
@@ -37,6 +37,23 @@
<relativePath>../</relativePath>
</parent>
+ <properties>
+
+ <!--
+ The location where temporary files should be stored for communicating
+ between karma and firefox. The default location, /tmp, does not work
+ if firefox is installed via snap.
+ -->
+ <firefox.temp.dir>${project.basedir}/.tmp</firefox.temp.dir>
Review Comment:
I think this should go beneath `${project.build.directory}` instead of
within the source tree.
##########
guacamole-docker/bin/build-guacamole.sh:
##########
@@ -43,10 +43,14 @@
## to empty string. Can be set to "lgpl-extensions" to e.g. include
## RADIUS authentication extension.
##
+## @param MAVEN_ARGUMENTS
+## Any number of arbitrary extra arguments to be passed to maven.
+##
BUILD_DIR="$1"
DESTINATION="$2"
BUILD_PROFILE="$3"
+MAVEN_ARGUMENTS="$4"
Review Comment:
`build-guacamole.sh` could leverage environment variables directly, using
positional arguments only for `BUILD_DIR` and `DESTINATION`. That would leave
us with `BUILD_DIR` and `MAVEN_ARGUMENTS` as build arguments that could be
defined in the `Dockerfile`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
