necouchman commented on PR #830:
URL: https://github.com/apache/guacamole-client/pull/830#issuecomment-1506238606

   > Had you considered allowing either the weekday or time parts of the 
restrictions to be left out, rather than requiring both? It looks like most of 
the code would already be pretty close to supporting that.
   
   I had thought about it, but not quite so thorougly.
   
   > An admin might prefer to add rule a that a user can access a connection 
from 9:00 to 17:00 every day, and also add a couple of rules that the user 
cannot access the connection on Saturday or Sunday.
   
   This should be pretty easy to do - I could add a RegEx/parsing rule that 
looks for an `*` to create a rule for every day. I could also look for values 
like "WD" for Week Day and "WE" for Week End.
   
   > As opposed to right now it looks like they'd have to add 5 rules, one for 
each day of the week, and if they wanted to change the hours, they'd have to 
change all 5 of the rules.
   
   Yep, that could be quite cumbersome.
   
   > If this is hard to implement, I'm fine with leaving it as a future 
enhancement,
   
   Nah, I'll take a run at it, I think it should be pretty easy. Thanks for the 
suggestion!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to