necouchman commented on code in PR #353: URL: https://github.com/apache/guacamole-server/pull/353#discussion_r1169370168
########## src/protocols/vnc/client.h: ########## @@ -54,6 +54,11 @@ */ #define GUAC_VNC_CLIPBOARD_MAX_LENGTH 262144 +/** + * The amount of time in milli-seconds to wait before sending a ping to VNC server. + */ +#define GUAC_VNC_IDLE_TIMEOUT 10000 Review Comment: I think this also may be mis-named - the name `GUAC_VNC_IDLE_TIMEOUT` implies that this is the time that the connection is idle before it times out. Based on the comment, though, I think maybe something like `GUAC_VNC_PING_INTERVAL` would be more appropriate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
