mike-jumper commented on code in PR #840:
URL: https://github.com/apache/guacamole-client/pull/840#discussion_r1173987909
##########
guacamole/src/main/java/org/apache/guacamole/rest/directory/DirectoryResource.java:
##########
@@ -590,7 +591,56 @@ public void executeOperation(boolean atomic,
Directory<InternalType> directory)
}
- // Append each identifier to the list, to be removed
atomically
+ else if (op == APIPatch.Operation.replace) {
+
+ // The identifier of the object to be replaced
+ String identifier = path.substring(1);
+
+ InternalType original = null;
+
+ try {
+
+ // Fetch the object to be updated
+ original = directory.get(identifier);
Review Comment:
If a user attempts to update a single connection via the non-batch REST API,
but that connection does not exist, they'll currently get a `GET` failure event
but no `UPDATE` failure event (the attempt to update doesn't occur because the
retrieval failed). Do you think these changes should match that behavior, or
that the REST API changes that are part of GUACAMOLE-1224 should be modified to
ensure both are fired?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
