mike-jumper commented on PR #429: URL: https://github.com/apache/guacamole-server/pull/429#issuecomment-1553313530
We use merge commits to represent merges of PRs to their target branch and merges of release branches (`staging/*`) back to `master`, so we avoid including merge commits within the set of commits in the PR itself. As for the commits on a PR, we don't specifically ask that contributors squash their commits except in cases where we end up with a set of commits where only one is meaningful, like: ``` GUACAMOLE-1234: Add support for [some specific high-level feature]. Update README.md. Update README.md. ``` In those cases, we point folks at https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/ and ask that they rebase/squash the commits such that they are either meaningful or do not exist. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
