jmuehlner commented on code in PR #891:
URL: https://github.com/apache/guacamole-client/pull/891#discussion_r1235724327
##########
guacamole-common-js/src/main/webapp/modules/SessionRecording.js:
##########
@@ -750,29 +750,38 @@ Guacamole.SessionRecording = function
SessionRecording(source, refreshInterval)
// Pull the upcoming frame
var next = frames[currentFrame + 1];
- // The position at which the next frame should be rendered, taking
- // into account any accumulated delays from rendering frames so far
- var nextFramePosition = next.timestamp - startVideoTimestamp +
startRealTimestamp;
Review Comment:
The big problem here is that this was supposed to be a _position_ within the
recording, but it's actually a browser _timestamp_, so it's going to be way
larger than the delay until the next `refreshInterval` update, meaning that the
timer will continuously tick up but no frames were ever rendered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
