mike-jumper commented on code in PR #895:
URL: https://github.com/apache/guacamole-client/pull/895#discussion_r1247226172
##########
guacamole-common-js/src/main/webapp/modules/Keyboard.js:
##########
@@ -1362,6 +1362,15 @@ Guacamole.Keyboard = function Keyboard(element) {
e.preventDefault();
+ // If unreliable caps lock was pressed and event was not marked,
then
+ // we need to pretend that this is a keydown event because we
obviously
+ // did not receive it (issue on macos with chrome)
+ if (e.keyCode == 20 && quirks.capsLockKeyupUnreliable) {
+ eventLog.push(new KeydownEvent(e));
+ interpret_events();
+ return;
+ }
Review Comment:
> I might look into that, but I would prefer to keep this refactoring
separated to a different PR and focus now on fixing the bug according to the
contribution guideline ...
Sounds good.
To clarify: there is no requirement that all bugfixes first enter the
codebase as minimal patches/hacks before a final, cleaner solution is later
contributed - that'd be technical debt. The "avoid commits which cover
multiple, distinct goals" refers to preferring to split changes across separate
commits where the separation makes sense, rather than contributing everything
as a single, monolithic commit. Large PRs consisting of a single, monolithic
commit can cause trouble down the line when tracing things back with `git
blame`. I don't anticipate this particular PR being that huge, but all that
requirement means is that the PR itself should contain multiple commits where
doing so makes logical sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
