[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #896: GUACAMOLE-1085: Migrate frontend to angular

[via GitHub]

jmuehlner commented on code in PR #896:
URL: https://github.com/apache/guacamole-client/pull/896#discussion_r1277908523


##########
guacamole/src/main/guacamole-frontend/package.json:
##########
@@ -0,0 +1,61 @@
+{
+    "name": "frontend",
+    "version": "0.0.0",
+    "scripts": {
+        "ng": "ng",
+        "start": "ng serve",
+        "build": "ng build",
+        "build:app": "ng build guacamole-frontend --base-href /guacamole/",

Review Comment:
   I just tried deploying this code and I noticed that all the resources are 
loaded at `/guacamole/` even though that's not where the webapp is deployed. Is 
there a way to make this dynamic? We can't safely assume that all users will 
always deploy their webapps at `/guacamole/`.
   
![image](https://github.com/apache/guacamole-client/assets/4633119/0fcb79fb-ee6e-46fb-bc01-31fa00196a49)
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org