jmuehlner commented on code in PR #454:
URL: https://github.com/apache/guacamole-server/pull/454#discussion_r1282412212
##########
src/guacd/proc.c:
##########
@@ -84,7 +102,11 @@ static void* guacd_user_thread(void* data) {
guac_client* client = proc->client;
/* Get guac_socket for user's file descriptor */
+#ifdef CYGWIN_BUILD
+ guac_socket* socket = guac_socket_open_handle(params->handle);
+#else
guac_socket* socket = guac_socket_open(params->fd);
+#endif
if (socket == NULL)
Review Comment:
Uh yeah, I guess so. Looks like this was a potential issue before, but none
of the `guac_socket*` functions look like they'll ever actually return `NULL`
so in practice it wouldn't happen. Better safe than sorry though.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
