darren-foley-bravurasecurity commented on code in PR #906:
URL: https://github.com/apache/guacamole-client/pull/906#discussion_r1303627512
##########
guacamole-common-js/src/main/webapp/modules/Parser.js:
##########
@@ -209,8 +209,14 @@ Guacamole.Parser = function Parser() {
// completely parsed, so that the next call to receive()
// need not append to the buffer unnecessarily
if (elementEnd + 1 === buffer.length) {
- elementEnd = -1;
- buffer = '';
+ if (isBuffer) {
+ startIndex = buffer.length;
+ break;
+ }
+ else {
+ elementEnd = -1;
+ buffer = '';
+ }
}
Review Comment:
I tested your suggestion: it was equally effective and much more concise :)
The PR has been updated
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
