jmuehlner commented on code in PR #455: URL: https://github.com/apache/guacamole-server/pull/455#discussion_r1308053921
########## src/protocols/kubernetes/argv.h: ########## @@ -70,5 +71,23 @@ guac_argv_callback guac_kubernetes_argv_callback; */ void* guac_kubernetes_send_current_argv(guac_user* user, void* data); +/** + * Sends the current values of all non-sensitive parameters which may be set + * while the connection is running to the all users associated with the + * provided socket. Note that the users receiving these values will not + * necessarily be able to set new values themselves if their connection is + * read-only. + * + * @param client + * The client associated with the users who should receive the values of + * all non-sensitive parameters which may be set while the connection is + * running. + * + * @return + * Always NULL. + */ +void* guac_kubernetes_send_current_argv_batch( Review Comment: Yes: https://github.com/jmuehlner/guacamole-server/blob/GUACAMOLE-1846-fix-user-join-race-condition-clean/src/protocols/kubernetes/kubernetes.c#L268 (same for the other protocols that still have it). ########## src/terminal/terminal/display.h: ########## @@ -340,6 +340,25 @@ void guac_terminal_display_flush(guac_terminal_display* display); void guac_terminal_display_dup(guac_terminal_display* display, guac_user* user, guac_socket* socket); +/** + * Initializes and syncs the current terminal display state for all joining + * users associated with the provided socket, sending the necessary instructions + * to completely recreate and redraw the terminal rendering over the given + * socket. + * + * @param display + * The terminal display to sync to the users associated with the provided + * socket. + * + * @param client + * The client whose users are joining. + * + * @param socket + * The socket over which any necessary instructions should be sent. + */ +void guac_terminal_display_dup_batch( + guac_terminal_display* display, guac_client* client, guac_socket* socket); Review Comment: Oops, yeah I'll get rid of this. I had mistakenly thought it was part of the public API. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
