jmuehlner commented on code in PR #459:
URL: https://github.com/apache/guacamole-server/pull/459#discussion_r1323660710
##########
src/libguac/client.c:
##########
@@ -185,6 +185,12 @@ static void guac_client_promote_pending_users(union sigval
data) {
/* Acquire the lock for reading and modifying the list of pending users */
guac_rwlock_acquire_write_lock(&(client->__pending_users_lock));
+ /* Skip user promotion entirely if there's no pending users */
+ if (client->__pending_users == NULL) {
+ guac_rwlock_release_lock(&(client->__pending_users_lock));
+ goto promotion_complete;
Review Comment:
Good call - it's done.
##########
src/libguac/client.c:
##########
@@ -185,6 +185,12 @@ static void guac_client_promote_pending_users(union sigval
data) {
/* Acquire the lock for reading and modifying the list of pending users */
guac_rwlock_acquire_write_lock(&(client->__pending_users_lock));
+ /* Skip user promotion entirely if there's no pending users */
+ if (client->__pending_users == NULL) {
+ guac_rwlock_release_lock(&(client->__pending_users_lock));
Review Comment:
Nope!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
