mike-jumper commented on code in PR #908:
URL: https://github.com/apache/guacamole-client/pull/908#discussion_r1338997239
##########
guacamole-common-js/src/main/webapp/modules/KeyEventInterpreter.js:
##########
@@ -283,7 +179,8 @@ Guacamole.KeyEventInterpreter = function
KeyEventInterpreter(batchSeperation, st
var name = String.fromCharCode(codepoint);
// Create and return the definition
- return new KeyDefinition({keysym: keysym, name: name, value: name,
modifier: false});
+ return new Guacamole.KeyEventInterpreter.KeyDefinition({
+ keysym: keysym, name: name, value: name);
Review Comment:
😋
##########
guacamole-common-js/src/main/webapp/modules/KeyEventInterpreter.js:
##########
@@ -283,7 +179,8 @@ Guacamole.KeyEventInterpreter = function
KeyEventInterpreter(batchSeperation, st
var name = String.fromCharCode(codepoint);
// Create and return the definition
- return new KeyDefinition({keysym: keysym, name: name, value: name,
modifier: false});
+ return new Guacamole.KeyEventInterpreter.KeyDefinition({
+ keysym: keysym, name: name, value: name);
Review Comment:
😋
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
