mike-jumper commented on PR #128:
URL: 
https://github.com/apache/guacamole-website/pull/128#issuecomment-1739862898

   Please also rebase to ensure your commits are individually meaningful and 
cover the high-level nature of the change made. The following:
   
   ![Screenshot of commits from PR 
#128](https://github.com/apache/guacamole-website/assets/4632905/92dba6b9-59cc-4ae4-b775-928fc968b3f6)
   
   does not add information to the commit history that would be of use to 
someone browsing that history, in particular the commits that read only "Add 
files via upload". A good blog post about this: 
https://www.codelord.net/2015/03/16/bad-commit-messages-hall-of-shame/
   
   Part of the middle commit reads "Adding Rampart AI™ as Commercial Support", 
which seems perfect. If things are rebased such that this is the message for 
the sole commit within this PR, I think that would make more sense.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to