sirux88 commented on PR #805: URL: https://github.com/apache/guacamole-client/pull/805#issuecomment-1781631750
I would add some thoughts: 1) What is the environment variabale `GUACD_SSL` for? As far as I can see it's not used on `guacamole-client` nor on `guacamole-server` anywhere (except within the changed files). Seems obsolete to me 2) Maybe the environment variables `GUACD_SSL_KEYSTORE_FILE` and `GUACD_SSL_KEYSTORE_PASS` should be renamed to something fitting better to their true purpose like `JAVA_KEYSTORE_FILE` and `JAVA_KEYSTORE_PASS` For reference: I had a similar approach here https://github.com/sirux88/guacamole-client/commit/e02d2bef55ee428c1da7eb1ecc7f77c7514588ad. My use case was using a self signed cert for LDAP -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
