fanovilla commented on code in PR #931:
URL: https://github.com/apache/guacamole-client/pull/931#discussion_r1395110120
##########
guacamole/src/main/java/org/apache/guacamole/tunnel/StandardTokenMap.java:
##########
@@ -102,6 +115,13 @@ public StandardTokenMap(AuthenticatedUser
authenticatedUser) {
else
put(USERNAME_TOKEN, authenticatedUser.getIdentifier());
+ if (get(USERNAME_TOKEN).contains("\\")) {
+ put(USERNAME_DOMAIN_TOKEN, get(USERNAME_TOKEN).split("\\\\")[0]);
+ put(USERNAME_ID_TOKEN, get(USERNAME_TOKEN).split("\\\\")[1]);
+ } else {
+ put(USERNAME_DOMAIN_TOKEN, "");
+ put(USERNAME_ID_TOKEN, get(USERNAME_TOKEN));
+ }
Review Comment:
You're right @necouchman , main intent is to expose a token (agree should be
LDAP specific) containing only the domain (and another containing only the
username) that can be used in connection definitions.
> We've provided a mechanism within the LDAP module (and most of the other
modules, particularly SSO) to define tokens specific to those modules, but that
should be usable in connections stored in other modules.
To do that, I presume we can add tokens to what's already being collected
here?https://github.com/apache/guacamole-client/blob/284d1b24f37f06d380312e149d24d96497dd9af4/extensions/guacamole-auth-ldap/src/main/java/org/apache/guacamole/auth/ldap/AuthenticationProviderService.java#L355-L358
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
