necouchman opened a new pull request, #469: URL: https://github.com/apache/guacamole-server/pull/469
This PR takes a crack at implementing the recently-added libvncclient support for `SendExtDesktopSize()`, which should allow Guacamole as a VNC client to send its size to VNC servers that support such functionality and have the display dynamically resized. I'm creating as a draft for the moment since I have not actually tested the functionality. Among the things I'm not sure of: * The RDP protocol contains a `resolution` setting which specifies the DPI resolution of the screen. I don't see any reason to try to mirror this into the VNC protocol, as I don't think VNC actually does anything with it (I think the DPI is fixed), but if I'm wrong let me know and I can add that support and try to update the code accordingly. * In the Jira issue (https://issues.apache.org/jira/browse/GUACAMOLE-1196), @mike-jumper mentioned a way of possibly sending the resize command/message using `WriteToRFBServer()` - I'm wondering if it's worth trying to implement the display update functionality with that in cases where libvncclient doesn't contain the `SendExtDesktopSize()` function? * I added the `message_lock` mutex for sending this message, as in the RDP protocol, but I don't know if there are other places where this lock should be used (authentication, for example), or if it's even required in this scenario? * I moved a few bits from the RDP protocol to the common/display.h file - among them are the minimum and maximum display size. It wasn't clear to me from the comments in the code whether those minimum and maximum sizes are arbitrary or if there's some particular reason those values are used? Not sure if there's something specific to RDP that has those bounds? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
