jmuehlner commented on code in PR #470:
URL: https://github.com/apache/guacamole-server/pull/470#discussion_r1437851223
##########
src/libguac/string.c:
##########
@@ -44,6 +45,22 @@
*/
#define REMAINING(n, length) (((n) < (length)) ? 0 : ((n) - (length)))
+size_t guac_itoa(char* restrict dest, int integer) {
+
+ /* Make sure memory is cleared. */
+ guac_mem_free(dest);
Review Comment:
What if somebody wants to write an integer value into something that can't
be freed, like a stack-allocated character buffer?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
