necouchman opened a new pull request, #472: URL: https://github.com/apache/guacamole-server/pull/472
This PR attempts to address the race condition associated with the RDP client join handler and the pipe svc attempt to access the available_svc member of the rdp_client data structure. I've taken both suggestions in one of the Jira tickets for 1) acquiring the overall lock and 2) doing a NULL check around available_svc before attempting to access it. It's worth noting that simply acquiring the lock on its own within the guac_rdp_join_pending_handler() function does not actually resolve the problem - the NULL check is required. So, I'm not sure in the lock is actually worth anything, or if there's somewhere else (around the SFTP connection, maybe?) that the lock should also be acquired? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
