jmuehlner commented on code in PR #470: URL: https://github.com/apache/guacamole-server/pull/470#discussion_r1437925731
########## src/libguac/string.c: ########## @@ -44,6 +45,16 @@ */ #define REMAINING(n, length) (((n) < (length)) ? 0 : ((n) - (length))) +size_t guac_itoa(char* restrict dest, int integer) { + + /* Determine size of string. */ + int str_size = snprintf(dest, 0, "%d", integer); Review Comment: Ugh, sorry I typed that backwards when I commented. `%i` is signed, and `%d` is unsigned. So this is still wrong. My bad. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org