jmuehlner commented on code in PR #939:
URL: https://github.com/apache/guacamole-client/pull/939#discussion_r1441007033
##########
guacamole/src/main/frontend/src/app/client/controllers/clientController.js:
##########
@@ -493,8 +493,7 @@ angular.module('client').controller('clientController',
['$scope', '$routeParams
// Update available connection parameters, if the updated arguments are
// for the current focused client - otherwise ignore them
if ($scope.focusedClient && $scope.focusedClient === focusedClient)
- $scope.menu.connectionParameters = focusedClient ?
Review Comment:
Coverity pointed out:
```
>>> CID 1560010: Control flow issues (DEADCODE)
>>> Execution cannot reach the expression "{}" inside this statement:
"$scope.menu.connectionParam...".
```
and it's not wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
