mike-jumper commented on code in PR #475:
URL: https://github.com/apache/guacamole-server/pull/475#discussion_r1443893093
##########
src/libguac/guacamole/recording.h:
##########
@@ -154,8 +164,8 @@ typedef struct guac_recording {
* recording will be written, NULL otherwise.
*/
guac_recording* guac_recording_create(guac_client* client,
- const char* path, const char* name, int create_path,
- int include_output, int include_mouse, int include_touch,
+ const char* path, const char* name, int create_path, mode_t
file_permissions,
+ mode_t path_permissions, int include_output, int include_mouse, int
include_touch,
Review Comment:
I'm not sure about directly coupling the API for screen recordings to
POSIX-specific `mode_t` when libguac is generally intended to support Windows
as a platform. Perhaps there's a way to implement this without making
`guac_recording_create()` non-portable?
If it were possible to implement this in a way that doesn't require
API/ABI-breaking changes, that would also be ideal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@guacamole.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
